• brbposting@sh.itjust.works
    link
    fedilink
    arrow-up
    9
    arrow-down
    1
    ·
    7 months ago

    What’s your opinion on this alternative verbiage?

    You copied that function without understanding why it does what it does, and as a result your code is flawed & inefficient. This poor practice is a pattern I’ve noticed.

    • Lvxferre@mander.xyz
      link
      fedilink
      arrow-up
      3
      arrow-down
      2
      ·
      edit-2
      7 months ago

      My opinion is that it is:

      1. Less likely to be effective. There’s a good chance that the submitter won’t get the message, and that they’ll submit another pull request, five minutes later, with the exact same issue that made the first PR to be rejected. And again. Again. Again.
      2. More insulting. Now you aren’t just saying “your code is garbage”; you’re saying “your code is garbage and you’re a fragile little thing that will break apart if handled incorrectly”.
      3. As likely to create drama as the original verbiage, given that the drama is originated in human nature - we humans want to believe (even if outright false) that we’re “contributing”, even when we are not.